Repository navigation
Skip IDEX low-rate waveform fits below 4.0 rms - #3600
Merged
lacoak21 merged 4 commits intoNov 10, 2026
Merged
Conversation
aldo9253
changed the title
aldo9253
marked this pull request as ready for review
November 2, 2026 21:34
lacoak21
self-requested a review
November 4, 2026 15:59
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the IDEX L2A signal-strength gating change.
No open issues 🎉
What changed in this PR
This PR adds a signal-strength gate to IDEX L2A processing so weak Target and Ion Grid waveforms are skipped rather than fitted.
Changes:
- Require a sample outside the first 3 µs to strictly exceed 4 × baseline RMS, with positive excursions for Targets and either polarity for Ion Grid.
- Return NaN fit products when a waveform fails the threshold or lacks finite baseline samples.
- Add tests for threshold boundaries, polarity, missing data, and independent event and channel processing.
| File | Description |
|---|---|
imap_processing/tests/idex/test_idex_signal_threshold.py |
Adds threshold and independent-processing tests. |
imap_processing/tests/idex/test_idex_l2a.py |
Updates expectations for nonfinite and constant waveforms. |
imap_processing/idex/idex_l2a.py |
Implements and documents the signal gate and NaN fallback. |
Review effort: Balanced
lacoak21
reviewed
Nov 9, 2026
lacoak21
left a comment
lacoak21
left a comment
Contributor
There was a problem hiding this comment.
Have a few suggestions before I approve
Collaborator
Author
|
Two comments addressed! |
Contributor
|
Thanks! |
lacoak21
self-requested a review
November 10, 2026 15:39
lacoak21
merged commit Nov 10, 2026
1cc9df8
into
IMAP-Science-Operations-Center:dev
22 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Overview
Require a sample beyond the first 3 µs to exceed 4 × baseline RMS before fitting Target or Ion Grid waveforms. Targets require positive excursions; Ion Grid allows either polarity.
File changes
idex_l2a.py: calculate the noise threshold and return NaN fit products for rejected waveforms.test_idex_signal_threshold.py,test_idex_l2a.py: verify threshold boundaries, polarity, missing data, and independent channel processing.Testing
222 IDEX tests passed; Local CDFs passed product checks and visual review at 4 × RMS