[lacoak21]

Change Summary

partially closes #3455

Overview

The CoDICE team would like to remove all neon data from the CDFs. This PR removes 'ne' from the global variable list.
The next step is to remove "ne" from the desired species list in the sci_lut.

File changes

• imap_processing/codice/constants.py
  • remove ne from the desired list

[Copilot]

🟡 Changes recommended

A critical inconsistency remains because removing ne from the shared species list leaves L1B converting it differently from the other species, and the related product documentation is also stale.

2 open issues

• Keep ne in L1B conversion until LUT removal is complete · New
• Update species inventory documentation and L2 relationship · New

What changed in this PR

This pull request begins removing neon (ne) from the CoDICE Lo species inventory used for product generation.

Changes:

• Removes ne from LO_SW_SPECIES_VARIABLE_NAMES.
• Prepares L1A processing for the planned SCI-LUT update.
• Requires coordinated updates to L1B conversion, L2 species handling, and documentation.

This pull request requires changes.

File	Review findings
imap_processing/​codice/​constants.py	Removing ne also affects L1B conversion while the SCI-LUT still emits it, causing inconsistent processing. The species inventory documentation is stale, and the L2 species list and related tests/configuration must be updated when neon removal is completed.

_{Review effort: Lite}

[Copilot]

🟡 Changes recommended

The implementation can silently drop requested LUT-driven species by replacing the SCI-LUT union with a fixed list, while documentation and tests also leave the Ne-removal contract insufficiently verified.

5 open issues

• Preserve the SCI-LUT union while excluding Ne · New
• Assert generated L1A omits Ne variables · New
• Assert generated L1B omits Ne variables · New
• Assert generated L2 omits Ne variables · New
• Update stale algorithm documentation for the LUT contract · New

2 resolved since last review

• Keep ne in L1B conversion until LUT removal is complete
• Update species inventory documentation and L2 relationship

_{Review effort: Lite}

[Copilot]

🔵 Needs a closer look

The two tests skip validating ne and unc_ne absence, allowing regressions that incorrectly retain these variables in the generated L1B or L2 datasets to pass.

No open issues 🎉

5 resolved since last review

• Preserve the SCI-LUT union while excluding Ne
• Assert generated L2 omits Ne variables
• Assert generated L1B omits Ne variables
• Assert generated L1A omits Ne variables
• Update stale algorithm documentation for the LUT contract

_{Review effort: Lite}