Repository navigation
Conversation
lacoak21
force-pushed
the
idex_fix_temperature_conversion_segmented_poly
branch
from
November 5, 2026 19:16
0fc3aaf to
9c56774
Compare
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Interval-grouping and uncertainty-masking defects can mix integrations, mispair livetime, and select invalid uncertainties, while L2 timestamps are also shifted 30 seconds late.
No open issues 🎉
What changed in this PR
This PR corrects IDEX processor-board temperature conversion in the shared engineering-unit pipeline. It also changes HIT processing to retain incomplete ten-minute sets and propagate their grouping through L1A–L2.
Changes:
- Add segmented temperature polynomials for both IDEX sensors and preserve floating-point conversion results.
- Rework HIT set identification, livetime normalization, and L2 grouping to accommodate dropped frames.
- Add regression tests and HIT header-minute-count metadata.
| File | Description |
|---|---|
imap_processing/utils.py |
Preserve floating-point results for segmented polynomials. |
imap_processing/tests/idex/test_idex_l1b.py |
Test temperature segment boundaries and negative results. |
imap_processing/tests/hit/test_hit_l2.py |
Update grouping fixtures and timestamp expectations. |
imap_processing/tests/hit/test_hit_l1b.py |
Test complete, incomplete, and mismatched livetime inputs. |
imap_processing/tests/hit/test_hit_l1a.py |
Expand partial-set and dropped-frame coverage. |
imap_processing/idex/idex_variable_unpacking_and_eu_conversion.csv |
Define four conversion segments per temperature sensor. |
imap_processing/hit/l2/hit_l2.py |
Group records by set and revise integration timestamps. |
imap_processing/hit/l1b/hit_l1b.py |
Scale partial-set livetime and retain header minute counts. |
imap_processing/hit/l1a/hit_l1a.py |
Retain incomplete sets and select predecessor livetime. |
imap_processing/cdf/config/imap_hit_l1b_variable_attrs.yaml |
Add header-minute-count support-variable metadata. |
Review effort: Balanced
lacoak21
commented
Nov 9, 2026
tmplummer
approved these changes
Nov 9, 2026
tmplummer
left a comment
tmplummer
left a comment
Contributor
There was a problem hiding this comment.
This looks good to me.
…tive converted values
Contributor
|
The fix looks good to me, though I'll admit I haven't tested the new code locally. |
leowerneck
approved these changes
Nov 9, 2026
lacoak21
merged commit Nov 10, 2026
bbdb97c
into
IMAP-Science-Operations-Center:dev
22 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
closes #3601
Overview
Fix temperature conversion.
File changes