fix: scope the models list to the caller's organization - #364
Merged
Merged
Conversation
Signed-off-by: Priyanshu-u07 <connect.priyanshu8271@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
list_modelsauthenticated the API key and then queried deployments with no organisation filter, so any valid key listed every org's running deployments. The cache key above it was already org-aware; the query it cached was not.Adds the org filter. Two things the issue notes go with it: other orgs' endpoints are no longer health-checked on every call, and pagination now counts only the caller's rows.
Worth calling out for review: the health-check loop decrypts each deployment's own credentials to probe it, so before this fix one tenant's model list made the gateway fire authenticated requests at every other tenant's inference endpoint, ten at a time.
Also returns an empty list when the key has no organisation. Not in the issue, but without it the query becomes org_id IS NULL and hands back every orgless deployment; the management endpoint already behaves this way.
Tests assert on the compiled SQL, since a mocked session returns whatever it's given regardless of the WHERE.
Closes #341