fix: capture a deployment logs before termination removes them - #366
Merged
Merged
Conversation
Signed-off-by: Priyanshu-u07 <connect.priyanshu8271@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TerminalLogRepository.save()had no callers, soGET /logs/{deployment_id}/persistedreturned nothing for every deployment on every provider.The capture now runs in
terminate_deployment_core, beforeunload_modelstops the engine — afterwards the pod is gone and the logs with it. It is best-effort and bounded at 10 seconds, so a slow or unreachable provider cannot stall or fail a termination. The tail is capped at 500 lines because the rows are written inside the termination transaction.FAILED and STOPPED are deliberately not wired, and the docstring now says so. STOPPED is set in a
finallyblock after cleanup has already recycled the nodes, so it needs its own pre-teardown capture point insideworker.py. Most FAILED transitions are provisioning failures where no engine ever started.Also removes the dangling
TerminalLogRepositoryconstruction inworker_main.pythat the issue names.Closes #360