Repository navigation
test: re-enable the OAuth router and rate limiter TTL suites - #376
Merged
Merged
Conversation
Signed-off-by: Priyanshu-u07 <connect.priyanshu8271@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two suites sat on the CI ignore list under "Currently failing". Both failed for reasons in the tests, not the code.
test_oauth_router.pybuilt its app withauth_provider="external", butis_external_modechecks for"oidc"or"inferiaauth". Every OAuth route returned 503 and all 17 tests failed. One word.test_rate_limiter_ttl.pyhad one flaky test. It drainedburst_sizetokens in a loop, but the defaults refill 166 a second and the loop takes about 9ms, so roughly 1.5 tokens flowed back before it checked and the bucket was never empty. It passed only when the loop beat ~6ms — one run in eight here. It now uses a small burst and no refill, measuring exhaustionrather than loop speed.29 tests re-enabled.
Part of #308