Skip to content

feat(iluvatar): enable modern Infini stack inference - #557

Open
gongchensu wants to merge 4 commits into
InfiniTensor:refactor/adopt-modern-infini-stackfrom
gongchensu:feat/iluvatar-modern-stack-inference
Open

feat(iluvatar): enable modern Infini stack inference#557
gongchensu wants to merge 4 commits into
InfiniTensor:refactor/adopt-modern-infini-stackfrom
gongchensu:feat/iluvatar-modern-stack-inference

Conversation

@gongchensu

@gongchensu gongchensu commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Add Iluvatar support to the modern InfiniLM stack builder in scripts/build_infini_stack.py, including InfiniRT, InfiniOps, and InfiniCCL configuration.
  • Enable Iluvatar inference through canonical InfiniOps attention APIs for static attention, paged attention, and explicit FlashAttention paths.
  • Route graph execution through the InfiniRT C++ segmented graph runtime.
  • Add the Iluvatar operator manifest, runtime contract tests, builder tests, and usage documentation.

Motivation

The refactor/adopt-modern-infini-stack branch requires platform integrations to use the standalone InfiniRT, InfiniOps, and InfiniCCL components instead of the legacy implementations previously contained in InfiniCore.

Before this change, InfiniLM did not accept iluvatar as a model runner device, the stack builder could not configure the Iluvatar toolchain, and the attention adapters did not register the canonical InfiniOps Iluvatar providers.

This change enables the 9G-8B model on Iluvatar BI-V150 through static attention, paged attention with InfiniRT graph execution, and explicit FlashAttention with InfiniRT graph execution.

N/A - no linked issue.

Type of Change

  • feat — new feature / new model
  • fix — bug fix
  • perf — performance improvement (no behavioral change)
  • refactor — code restructuring without behavior change
  • test — adding or fixing tests only
  • docs — documentation only
  • build / ci — build system or CI configuration
  • chore — tooling, formatting, or other non-code changes
  • Breaking change

Test Results of Involved Models on Supported Platforms (Please attach screenshots)

Benchmark / Performance Impact

Notes for Reviewers

CI / ChatOps


Checklist

Every contributor must verify every item below before requesting
review. Tick each box only after the check has actually been performed —
do not tick speculatively. If an item truly does not apply, replace the
checkbox with N/A and briefly explain why in an inline comment.

Title, Branch, and Commits

  • PR title follows Conventional Commits (e.g. feat(nvidia): …, fix(cuda/gemm): …).
  • Branch name follows <type>/xxx-yyyy-zzzz where <type> matches the PR title's Conventional Commits type and words are joined with hyphens (see CONTRIBUTING.md §Branches).
  • Each commit message follows Conventional Commits.
  • Small PR is a single squashable commit; or, for a large PR, every commit is meaningful, well-formed, and independently reviewable (see CONTRIBUTING.md §Pull Requests).
  • No stray merge commits from main — the branch is rebased cleanly on top of the current main.
  • No fixup! / squash! / wip commits remain.
  • Existing PR/branch/commit that followed the legacy issue format.

Scope and Design

  • Changes are minimal — nothing unrelated to the stated motivation was added (CONTRIBUTING.md §Code/General).
  • No dead code, commented-out blocks, debug prints, printf/std::cout/print(...) left behind, or TODO without an owner and issue link.
  • No unrelated formatting churn that would obscure the diff.
  • Public API changes (if any) are intentional, documented, and reflected in affected callers/tests.

General Code Hygiene (applies to all languages)

  • The code is self-explanatory; comments were added only where the why is non-obvious (CONTRIBUTING.md §Code/General).
  • Every modified or added file ends with a single trailing newline (CONTRIBUTING.md §Code/General).
  • No trailing whitespace, tab/space mixing, or stray BOMs.
  • Identifiers in comments and error messages are wrapped in backticks (e.g. the `seqlens_k` tensor) (CONTRIBUTING.md §Code/General).
  • All comments and error messages are in English (CONTRIBUTING.md §Code/General).
  • Comments and error messages are complete sentences — capitalized first letter, terminal punctuation — unless the language/framework convention says otherwise (CONTRIBUTING.md §Code/General; §Python).

C++ Specific (if C++ files changed)

  • Code follows the Google C++ Style Guide strictly.
  • Error and warning message wording follows the LLVM Coding Standards (CONTRIBUTING.md §C++).
  • Constructor initializer list order matches member declaration order (CONTRIBUTING.md §C++).
  • No raw new/delete; RAII / smart pointers / existing allocators are used.
  • Changed files are formatted by scripts/format.py.
  • No changes/reference to csrc/models/llama_legacy/.

Python Specific (if Python files changed)

  • Code is PEP 8 compliant.
  • Comments are complete English sentences, starting with a capital letter and ending with punctuation; Markdown backticks are used for code references (CONTRIBUTING.md §Python).
  • Docstrings (if any) follow PEP 257 (CONTRIBUTING.md §Python).
  • Changed files are formatted by scripts/format.py.
  • No changes/reference to python/infinilm/auto_config.py.

Testing

  • For any platform that could not be tested, an explicit reason is given in the table and a reviewer with access has been tagged.
  • Passed single request test (examples/test_infer.py), or specify the reason for skipping.
  • Passed offline performance test (examples/bench.py), or specify the reason for skipping.
  • Passed sanity test (test/bench/test_benchmark.py), or specify the reason for skipping.
  • Passed service test (python/infinilm/server/inference_server.py + scripts/test_perf.py), or specify the reason for skipping.

Build, CI, and Tooling

  • The project builds cleanly from a fresh directory on at least one affected platform.
  • CI has been triggered manually (Actions → CI on this branch), or /retest was requested.

Documentation

  • README.md, CONTRIBUTING.md, or inline docs updated when behavior, build flags, or developer workflow changed.
  • Any user-visible breaking change is called out explicitly under "Motivation" and in the commit/PR title with a ! or BREAKING CHANGE: footer.

Security and Safety

  • No secrets, access tokens, internal URLs, customer data, or personal hardware identifiers have been committed.
  • Third-party code is license-compatible and attributed.
  • No unsafe pointer arithmetic, uninitialized reads, or missing bounds checks were introduced.

@gongchensu
gongchensu requested a review from voltjia September 3, 2026 08:52
@gongchensu gongchensu self-assigned this Sep 3, 2026
Comment on lines +17 to +26
std::size_t implementation_index_for_device(
infini::ops::Device::Type device_type) {
if (device_type == infini::ops::Device::Type::kIluvatar) {
return 0;
}
if (device_type == infini::ops::Device::Type::kMoore) {
return 8;
}
return 16;
}

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这块加个 TODO 吧,感觉老师应该不希望 InfiniLM 里面有这种东西 hhh,后面看看怎么办吧。

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个文件可以本地留存一份,但是先不放到 InfiniLM 仓库里。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants