Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces #109, which was accidentally closed and its source fork deleted. The implementation is unchanged; the original discussion and reviews remain linked there.
Pickling a
DefaultFactoryMunch(list, existing=[1])currently discardsdefault_factory. Accessing a missing attribute on the restored object then raisesRecursionError, because looking up the missing factory invokes__missing__again.Store the factory alongside the dictionary state and restore it before the items. This also preserves nested
RecursiveMunchbehavior. Regression tests cover all six pickle protocols, independent default values, and recursive factories.Validation: 122 tests pass on Python 3.11 with PyYAML. The six original factory regressions failed before the fix. The optional module doctests have four pre-existing failures (dictionary ordering, multiline output, and the old
yaml.loadcall); the same four failures were verified on unchanged HEAD.