Fix/theme native colors - #24
Merged
jaimegh-es merged 3 commits intoSep 11, 2026
Merged
Conversation
OshriFatkiev
force-pushed
the
fix/theme-native-colors
branch
from
September 3, 2026 12:19
f582a00 to
fe2c325
Compare
Member
|
Hello! |
OshriFatkiev
force-pushed
the
fix/theme-native-colors
branch
from
September 7, 2026 05:15
a223ec0 to
58ec29e
Compare
Member
|
Hello again! reviewing now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a light theme the popup was close to unreadable - the hardcoded white overlays and
#eeeeee/#aaaaaatext assumed a dark shell. Colors now come from the theme: neutral grey overlays, and no explicitcoloron text so it inherits the shell foreground.Secondary text is dimmed with actor
opacityrather than a fixed color - St has no CSSopacity, and the shell only dims text via per-themergba()foregrounds, which needs the separate light/dark stylesheets an extension doesn't have.Second commit shrinks and centres the panel indicator.
Tested on GNOME Shell 46.