fix(matrix): named refusals and whole-pixel floors; POST body reaches every field - #7
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Seven bugs survived the matrix repair on
mainbecause nothing tested for them. Two are user-facing: a headline chip wider than the masthead ran outside the frame with no error, andPOST /v1/composeaccepted 24 of the 46ComposeSpecfields and ignored the rest in silence. All seven now have tests.Changes
MatrixCapacityErrorwith the space needed and the space available. Next to a title, the chip leaves room for the gap and the title's shortest truncation.widthnarrower than the column's content is widened to fit, with adeclared-widthdiagnostic. The matrix refuses only when the columns cannot fit 900px at their narrowest.text_floorrounds up. A column set to its own minimum used to truncate the text that minimum came from, because the two differed by a fraction of a pixel.truncate_to_widthreturns nothing when even…does not fit.fit_lineandfitreport the overflow.1k · 2k · 3kinstead of1000k. Millions stayM._fmt_tickis replaced byformat_compact_numberwith alower_koption.metric_text_x,text_inset, andstrip_metric_text_xare deleted. Nothing read them.ComposeRequestgains 13 fields includingfont_mode, on the inline and envelope paths. Unknown keys return inwarnings, orX-HW-Warningfor svg. The other 13 fields are internal and listed intests/serve/test_compose_body.py, so adding one forces a choice._test_*.svgignored, connectors example regenerated, corpus re-recorded.Validation
mainruff check·ruff format --check·ty checkjust qaNothing visible moved. 14 measurements shifted by at most 1px and the connectors asset by 0.05px.
Notes
formatis reported but ignored on inlinesvgandjson. It works onenvelopeandreport, which serve a file aturl.