Repository navigation
build(goi18n): require the core v0.2.0 - #84
Merged
Merged
Conversation
The module required the pseudo-version v0.0.0-00010101000000-000000000000 of the core added by go get with the replace; the users can't download it, the replace is ignored for them.
Contributor
Benchmark diff:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #84 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 40 40
Lines 1865 1865
=========================================
Hits 1865 1865 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goi18n module required the pseudo-version
v0.0.0-00010101000000-000000000000of the core, added bygo getwith thereplace: the users can't download it, their builds ignore the replace. It requires v0.2.0 with the sources of translations now.scripts/check-modules.shchecks in CI that every module ofmodules.shrequires a released version of the core.The tag
integrations/goi18n/v0.1.0points to the last commit of this branch: it is merged by a fast-forward of main, so the commits keep their hashes.