Skip to content

build(goi18n): require the core v0.2.0 - #84

Merged
Insei merged 2 commits into
mainfrom
build/goi18n-core-0.2.0
Oct 19, 2026
Merged

Insei merged 2 commits into
mainfrom
build/goi18n-core-0.2.0

Conversation

@Insei

@Insei Insei commented Oct 19, 2026

Copy link
Copy Markdown
Owner

The goi18n module required the pseudo-version v0.0.0-00010101000000-000000000000 of the core, added by go get with the replace: the users can't download it, their builds ignore the replace. It requires v0.2.0 with the sources of translations now. scripts/check-modules.sh checks in CI that every module of modules.sh requires a released version of the core.

The tag integrations/goi18n/v0.1.0 points to the last commit of this branch: it is merged by a fast-forward of main, so the commits keep their hashes.

Insei added 2 commits October 19, 2026 13:49
The module required the pseudo-version v0.0.0-00010101000000-000000000000
of the core added by go get with the replace; the users can't download
it, the replace is ignored for them.
@github-actions

Copy link
Copy Markdown
Contributor

Benchmark diff: 01ca5fc → bfcae28 (10 runs)

goos: linux
goarch: amd64
pkg: github.com/insei/valigo
cpu: AMD EPYC 7763 64-Core Processor                
           │  base.txt   │              head.txt              │
           │   sec/op    │   sec/op     vs base               │
Validate-4   146.3n ± 1%   148.0n ± 3%  +1.13% (p=0.045 n=10)

           │  base.txt  │            head.txt            │
           │    B/op    │    B/op     vs base            │
Validate-4   0.000 ± 0%   0.000 ± 0%  ~ (p=1.000 n=10) ¹
¹ all samples are equal

           │  base.txt  │            head.txt            │
           │ allocs/op  │ allocs/op   vs base            │
Validate-4   0.000 ± 0%   0.000 ± 0%  ~ (p=1.000 n=10) ¹
¹ all samples are equal

@codecov-commenter

codecov-commenter commented Oct 19, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (01ca5fc) to head (381090d).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #84   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           40        40           
  Lines         1865      1865           
=========================================
  Hits          1865      1865           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Insei
Insei merged commit 381090d into main Oct 19, 2026
7 checks passed
@Insei
Insei deleted the build/goi18n-core-0.2.0 branch October 19, 2026 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants