Skip to content

BUG: Let ReadImageInformation succeed for unconfigured codecs #6913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blowekamp merged 1 commit into from
Sep 28, 2026
+13 −10
Merged

BUG: Let ReadImageInformation succeed for unconfigured codecs #6913

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 13 additions & 10 deletions Modules/IO/TIFF/src/itkTIFFImageIO.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -497,17 +497,9 @@ TIFFImageIO::ReadImageInformation()
}


if (!m_InternalImage->CanRead())
// Metadata stays inspectable without codec support; Read() reports the decode failure.
if (!m_InternalImage->CanRead() && TIFFIsCODECConfigured(this->m_InternalImage->m_Compression) == 1)
{
// exception if compression is not supported
if (TIFFIsCODECConfigured(this->m_InternalImage->m_Compression) != 1)
{
const TIFFCodec * c = TIFFFindCODEC(this->m_InternalImage->m_Compression);
const char * codecName = (c != nullptr) ? static_cast<const char *>(c->name) : "unknown";

itkExceptionMacro("TIFF CODEC \"" << codecName << "\" is not supported.");
}

char emsg[1024];
if (TIFFRGBAImageOK(m_InternalImage->m_Image, emsg) != 1)
{
Expand Down Expand Up @@ -1323,6 +1315,17 @@ TIFFImageIO::ReadCurrentPage(void * buffer, size_t pixelOffset)

if (!m_InternalImage->CanRead())
{
if (TIFFIsCODECConfigured(this->m_InternalImage->m_Compression) != 1)
Comment thread
blowekamp marked this conversation as resolved.
{
const TIFFCodec * c = TIFFFindCODEC(this->m_InternalImage->m_Compression);

if (c != nullptr)
{
itkExceptionMacro("TIFF CODEC \"" << c->name << "\" is not supported.");
}
itkExceptionMacro("TIFF CODEC " << this->m_InternalImage->m_Compression << " is not supported.");
}

uint32_t * tempImage = nullptr;

if (this->GetNumberOfComponents() == 4 && m_ComponentType == IOComponentEnum::UCHAR)
Expand Down
Loading