Conversation
github-actions
Bot
added
type:Enhancement
Merge baseline tags (BitsPerSample, Compression, dimensions, tiling, resolution, etc.) and RowsPerStrip/SampleFormat into ReadTIFFTags's generic fetch loop, rather than only custom tags. Add TIFF_RATIONAL/ SRATIONAL support, and use TIFFGetFieldDefaulted so spec-mandated defaults are captured. Replace manual _TIFFfree bookkeeping with a unique_ptr so the self-allocated buffer is freed via RAII.
blowekamp
force-pushed
the
tiff-readtags-baseline-metadata
branch
from
September 29, 2026 15:03
74dd5f6 to
f58f93b
Compare
dzenanz
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge TIFF baseline tags (BitsPerSample, Compression, dimensions, tiling geometry, resolution, etc.) and RowsPerStrip/SampleFormat into
ReadTIFFTags's generic fetch loop, so they appear in the ImageIO metadata dictionary alongside custom tags instead of only custom tags being exposed.Details
TIFFGetFieldDefaultedso spec-mandated defaults (e.g. BitsPerSample) are captured even when absent from the file._TIFFfree/bool bookkeeping with astd::unique_ptrcustom deleter so the self-allocated buffer is freed via RAII on every exit path.Test results
ctest -R "TIFF" --output-on-failure— 113/113 passed.