ENH: Add .gitattributes file for linter action - #171
Merged
Merged
Conversation
dzenanz
force-pushed
the
linterGitAttributes
branch
2 times, most recently
from
September 29, 2026 18:13
ce1adc9 to
1d89e26
Compare
See InsightSoftwareConsortium/ITKClangFormatLinterAction#24 File taken from InsightSoftwareConsortium/ITKThinShellDemons#27 Note: the module template no longer passes it, so remove clang-format-linter.yml from here.
dzenanz
force-pushed
the
linterGitAttributes
branch
from
September 29, 2026 18:17
1d89e26 to
a609ce7
Compare
dzenanz
requested review from
blowekamp,
hjmjohnson,
jhlegarreta and
thewtex
September 29, 2026 19:00
Member
|
Why is the Python build / test / package removed? |
Member
Author
|
It fails for the cookie cutter template part. Can we maintain it? |
Member
|
I think it should be maintained. It is some work, but it will avoid more issues and confusion when people start from a broken template. |
Member
Author
|
I can skip that commit, and merge the rest. Does the rest look OK? |
Member
|
Yes, thanks! |
dzenanz
force-pushed
the
linterGitAttributes
branch
from
September 30, 2026 13:53
54a3760 to
ca1c21c
Compare
thewtex
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See InsightSoftwareConsortium/ITKClangFormatLinterAction#24
File taken from InsightSoftwareConsortium/ITKThinShellDemons#27