Conversation
POST /timeseries/update answered every validation failure with a
NullPointerException. The per-field error branch built a ResponseError
and never put a BadRequestError inside it, so the first addFieldError
dereferenced null:
ResponseError<BadRequestError> errors = new ResponseError<>();
ts.getUpdate().getErrors().forEach(error ->
errors.getError().addFieldError(...)); // getError() is null
Reachable from any rule in TimeseriesFields.validateUpdateFields — a
name under three characters is enough. The endpoint documents a 400 with
the offending fields; callers got a bare 500 and no indication of which
field was wrong.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Signed-off-by: jgjesdal <jostein@intellistream.ai>
…s 500 Two endpoints whose catch-all turned a verdict into a server fault. A 500 tells the caller the server broke and the request is worth retrying; both of these will fail identically until the caller changes something. POST /policies/delete reaches the shared resource-delete pipeline through PolicyService.deletePolicies, so it is subject to the same stranded-node guard as every other delete and asserts write on the policy's data set. It was the one delete endpoint with no ResourceDeleteException catch, so a refusal — which carries the offending resources — came back as a bodyless 500 naming nothing, and a denial came back the same way. POST /subscriptions/create asserts read on every timeseries the body names (SubscriptionService:103), so subscribing to a series in an unreadable data set is a denial. The broad RuntimeException catch reported it as a server fault. Both surface through handlers that already exist, in the shape those handlers already produce, so no response shape changes. The other fourteen catch-alls call services that narrow by readable data set rather than asserting, so they never raise AccessDeniedException and are left alone. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: jgjesdal <jostein@intellistream.ai>
olavgg
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
How it was verified
Checklist
git commit -s), per CONTRIBUTING.md./gradlew buildpasses(see AGENTS.md for which of the two documentation sites it belongs in)