Drop the timeseries tableEngine field, which the api is removing - #115
Merged
Conversation
No read has returned tableEngine since the api marked it @JsonIgnore: which ClickHouse engine backs a series is an internal storage decision, not part of the entity. The field was kept anyway because create still accepted it, so it was write-only in practice and always None on the way back. The api is now removing it outright, which takes that last reason with it - and since request bodies are read strictly, a body still naming it would be a 400. Gone from TimeSeries and both its constructors, from the PyO3 constructor and getter, from the stub, and from the tests that pinned it as always-None. Also from the node serialization test's foreign/own field lists, so a timeseries no longer claims a field it does not have. Safe to land in either order relative to the api: nothing in this SDK ever set the field (there is no setter, and skip_serializing_if kept it off the wire), and responses stay lenient, so a response that still carries it deserializes fine. src/resources/tests.rs keeps its reference to the @JsonIgnore change in d70b57ad - that is a record of what the parity test found, still accurate. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: jgjesdal <jostein@intellistream.ai>
olavgg
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No read has returned tableEngine since the api marked it @JsonIgnore: which ClickHouse engine backs a series is an internal storage decision, not part of the entity. The field was kept anyway because create still accepted it, so it was write-only in practice and always None on the way back. The api is now removing it outright, which takes that last reason with it - and since request bodies are read strictly, a body still naming it would be a 400.
Gone from TimeSeries and both its constructors, from the PyO3 constructor and getter, from the stub, and from the tests that pinned it as always-None. Also from the node serialization test's foreign/own field lists, so a timeseries no longer claims a field it does not have.
Safe to land in either order relative to the api: nothing in this SDK ever set the field (there is no setter, and skip_serializing_if kept it off the wire), and responses stay lenient, so a response that still carries it deserializes fine. src/resources/tests.rs keeps its reference to the @JsonIgnore change in d70b57ad - that is a record of what the parity test found, still accurate.