fix: subscriptions list moved to POST /subscriptions/filter - #116
Open
olavgg wants to merge 1 commit into
Open
Conversation
The api put subscriptions on the same filter contract as every other collection
(datahub-platform d190ffe4, merged 8 September). `POST /subscriptions/list` is
gone rather than deprecated, so `subscriptions.list()` 404s against current
master:
{"status":404,"error":"Not Found","path":"/subscriptions/list"}
Only the path moved. `SubscriptionFilterForm` still serializes to `filter`,
`limit` and `sort`, which the endpoint reads exactly as `/list` did, and the type
is a strict field-subset of the `SubscriptionRetriever` it now accepts — the api
grew `id`, `externalId`, `name`, `createdTime` and `lastUpdatedTime` criteria plus
a `cursor` this form does not send yet.
The name stays `list` where the Java client spells the same call `filter`. Making
the three agree is a rename, and the `GET /subscriptions?limit=` listing the api
gained alongside is an addition; both are worth doing and neither belongs in a
repair that should stay revertable on its own.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012CrLKgoRmcBYFJ6ukYzf2t
Signed-off-by: samuel <samuel@intellistream.ai>
JosteinGj
reviewed
Sep 9, 2026
| /// the three is worth doing on its own, together with the `GET /subscriptions?limit=` listing | ||
| /// the api gained at the same time and no client wraps yet — both are renames and additions | ||
| /// rather than repairs, and this change is meant to be revertable on its own. | ||
| pub async fn list( |
Contributor
There was a problem hiding this comment.
either this is list or its filter. this line needs to change as well, we dont want a method list() that calls filter
JosteinGj
requested changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The api put subscriptions on the same filter contract as every other collection (datahub-platform d190ffe4, merged 8 September).
POST /subscriptions/listis gone rather than deprecated, sosubscriptions.list()404s against current master:Only the path moved.
SubscriptionFilterFormstill serializes tofilter,limitandsort, which the endpoint reads exactly as/listdid, and the type is a strict field-subset of theSubscriptionRetrieverit now accepts — the api grewid,externalId,name,createdTimeandlastUpdatedTimecriteria plus acursorthis form does not send yet.The name stays
listwhere the Java client spells the same callfilter. Making the three agree is a rename, and theGET /subscriptions?limit=listing the api gained alongside is an addition; both are worth doing and neither belongs in a repair that should stay revertable on its own.Claude-Session: https://claude.ai/code/session_012CrLKgoRmcBYFJ6ukYzf2t