Repository navigation
Add Ascend Dlinfer BuildSpec implementations for Qwen3.5 GDN - #4999
Open
wanfengcxz wants to merge 3 commits into
Open
wanfengcxz wants to merge 3 commits into
wanfengcxz wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Unresolved critical state-layout and cache-handling issues block approval.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 3
Open (3)
What changed in this PR
Adds Ascend/Dlinfer BuildSpec implementations for Qwen3.5 GDN operations.
Changes:
- Registers three Ascend BuildSpecs.
- Adds causal-convolution and gated-delta kernel adapters.
- Supports Ascend metadata and recurrent-state handling.
| File | Summary |
|---|---|
lmdeploy/pytorch/backends/dlinfer/ascend/op_backend.py |
Dispatches the three Ascend BuildSpecs. |
lmdeploy/pytorch/backends/dlinfer/ascend/gated_delta_rule.py |
Implements GDN metadata and execution; critical state-index and layout issues remain. |
lmdeploy/pytorch/backends/dlinfer/ascend/causal_conv1d.py |
Wraps causal-convolution kernels; critical cache-layout and moderate sequence-boundary issues remain. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
wanfengcxz
force-pushed
the
fix/qwen35-gdn-ascend-specs
branch
from
October 21, 2026 09:44
bcbb903 to
b3165c9
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Qwen3.5 GDN currently fails on the Ascend/Dlinfer backend because three BuildSpecs are not implemented.
This PR adds Ascend implementations for:
The changes are isolated to the Ascend/Dlinfer backend and do not modify CUDA or shared LMDeploy logic.
Validated with Qwen3.5 offline inference on Ascend cards.
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist