Repository navigation
Fix testLawsGroup failing to compile with QuickCheck < 2.18 - #704
Open
koslambrou wants to merge 1 commit into
Open
koslambrou wants to merge 1 commit into
koslambrou wants to merge 1 commit into
Conversation
The imports that `testLawsGroup` needs were only brought into scope inside the `#if MIN_VERSION_QuickCheck(2, 18, 0)` branch, even though `testLawsGroup` itself is defined unconditionally. Move those imports out of the CPP guard, which only needs to gate the `withNumTests`/`withMaxSuccess` compatibility shim. Bump to 0.1.7.1, since 0.1.7.0 was already released to CHaP with this bug.
koslambrou
force-pushed
the
koslambrou/fix-testlawsgroup
branch
from
October 14, 2026 12:14
1366667 to
c79b5f1
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The imports that
testLawsGroupneeds were only brought into scope inside the#if MIN_VERSION_QuickCheck(2, 18, 0)branch, even thoughtestLawsGroupitself is defined unconditionally. Move those imports out of the CPP guard, which only needs to gate thewithNumTests/withMaxSuccesscompatibility shim.Bump to 0.1.7.1, since 0.1.7.0 was already released to CHaP with this bug.
Description
Checklist
CHANGELOG.mdfor the affected packages.New section is never added with the code changes. (See RELEASING.md)
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated.If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)