Repository navigation
Show direct deposits in transaction views - #1470
Merged
Merged
Conversation
Jimbo4350
marked this pull request as ready for review
October 15, 2026 19:06
Jimbo4350
requested review from
carbolymer,
disassembler,
kevinhammond and
palas
as code owners
October 15, 2026 19:06
Jimbo4350
force-pushed
the
fix/cip159-deposit-view
branch
2 times, most recently
from
October 15, 2026 19:12
beadab8 to
d1a6689
Compare
Jimbo4350
force-pushed
the
feature/cip159-account-build-flags
branch
from
October 15, 2026 19:12
7fc8240 to
cea9124
Compare
carbolymer
approved these changes
Oct 16, 2026
Jimbo4350
force-pushed
the
feature/cip159-account-build-flags
branch
from
October 16, 2026 14:55
34e09e0 to
5990207
Compare
1 of 17 tasks
Jimbo4350
force-pushed
the
fix/cip159-deposit-view
branch
from
October 22, 2026 14:49
d1a6689 to
2e0a58f
Compare
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused rendering change preserves existing behavior, has regression coverage for both output formats, and has no identified blocking issues.
No open issues 🎉
What changed in this PR
This follow-up to #1469 makes direct-deposit recipients and amounts visible in Dijkstra transaction views, using the existing withdrawal format.
Changes:
- Adds Dijkstra-only direct-deposit rendering while preserving Conway output.
- Adds JSON and YAML golden tests covering two recipients.
- Adds a bugfix changelog fragment for #1470.
| File | Description |
|---|---|
cardano-cli/test/cardano-cli-golden/Test/Golden/Debug/TransactionView.hs |
Adds direct-deposit transaction-view tests for both formats. |
cardano-cli/test/cardano-cli-golden/files/golden/dijkstra/transaction-view-direct-deposits.yaml |
Records expected YAML output for two recipients. |
cardano-cli/test/cardano-cli-golden/files/golden/dijkstra/transaction-view-direct-deposits.json |
Records expected JSON output for two recipients. |
cardano-cli/src/Cardano/CLI/Compatible/Json/Friendly.hs |
Renders direct deposits using shared account-and-amount formatting. |
.changes/20261015_cip159_deposit_view.yml |
Documents the transaction-view bugfix. |
Review effort: Balanced
Jimbo4350
enabled auto-merge
October 22, 2026 16:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dijkstra transactions built with
--direct-depositcurrently omit the recipient and amount fromdebug transaction view. This renders direct deposits in both JSON and YAML, using the same account and amount format as withdrawals.Stacked on #1469 and targeting
feature/cip159-account-build-flags. The diff contains only the follow-up commit.Adds JSON/YAML golden tests for two recipients and a separate Herald fragment for #1470 with a single-line description.
Validation on GHC 9.12.4:
git diff --checkpassed.No live node submission tests were run.