Skip to content

Show direct deposits in transaction views - #1470

Merged
Jimbo4350 merged 3 commits into
masterfrom
fix/cip159-deposit-view
Oct 22, 2026
Merged

Jimbo4350 merged 3 commits into
masterfrom
fix/cip159-deposit-view

Conversation

@Jimbo4350

@Jimbo4350 Jimbo4350 commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Dijkstra transactions built with --direct-deposit currently omit the recipient and amount from debug transaction view. This renders direct deposits in both JSON and YAML, using the same account and amount format as withdrawals.

Stacked on #1469 and targeting feature/cip159-account-build-flags. The diff contains only the follow-up commit.

Adds JSON/YAML golden tests for two recipients and a separate Herald fragment for #1470 with a single-line description.

Validation on GHC 9.12.4:

  • Executable and both test suites built successfully.
  • 634 selected golden tests passed, including the JSON/YAML transaction-view tests.
  • Fourmolu, HLint, and git diff --check passed.

No live node submission tests were run.

@Jimbo4350
Jimbo4350 marked this pull request as ready for review October 15, 2026 19:06
@Jimbo4350
Jimbo4350 force-pushed the fix/cip159-deposit-view branch 2 times, most recently from beadab8 to d1a6689 Compare October 15, 2026 19:12
@Jimbo4350
Jimbo4350 force-pushed the feature/cip159-account-build-flags branch from 7fc8240 to cea9124 Compare October 15, 2026 19:12
@Jimbo4350 Jimbo4350 changed the title Show direct deposits in transaction views and test multiple recipients Show direct deposits in transaction views Oct 15, 2026
@Jimbo4350
Jimbo4350 force-pushed the feature/cip159-account-build-flags branch from 34e09e0 to 5990207 Compare October 16, 2026 14:55
Base automatically changed from feature/cip159-account-build-flags to master October 16, 2026 16:20
Copilot AI balanced review requested due to automatic review settings October 22, 2026 14:49
@Jimbo4350
Jimbo4350 force-pushed the fix/cip159-deposit-view branch from d1a6689 to 2e0a58f Compare October 22, 2026 14:49

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused rendering change preserves existing behavior, has regression coverage for both output formats, and has no identified blocking issues.

No open issues 🎉

What changed in this PR

This follow-up to #1469 makes direct-deposit recipients and amounts visible in Dijkstra transaction views, using the existing withdrawal format.

Changes:

  • Adds Dijkstra-only direct-deposit rendering while preserving Conway output.
  • Adds JSON and YAML golden tests covering two recipients.
  • Adds a bugfix changelog fragment for #1470.
File Description
cardano-cli/​test/​cardano-cli-golden/​Test/​Golden/​Debug/​TransactionView.hs Adds direct-deposit transaction-view tests for both formats.
cardano-cli/​test/​cardano-cli-golden/​files/​golden/​dijkstra/​transaction-view-direct-deposits.yaml Records expected YAML output for two recipients.
cardano-cli/​test/​cardano-cli-golden/​files/​golden/​dijkstra/​transaction-view-direct-deposits.json Records expected JSON output for two recipients.
cardano-cli/​src/​Cardano/​CLI/​Compatible/​Json/​Friendly.hs Renders direct deposits using shared account-and-amount formatting.
.changes/​20261015_cip159_deposit_view.yml Documents the transaction-view bugfix.

Review effort: Balanced

@Jimbo4350
Jimbo4350 enabled auto-merge October 22, 2026 16:40
@Jimbo4350
Jimbo4350 requested a review from a team as a code owner October 22, 2026 19:24
@Jimbo4350
Jimbo4350 added this pull request to the merge queue Oct 22, 2026
Merged via the queue into master with commit 900a62f Oct 22, 2026
25 of 26 checks passed
@Jimbo4350
Jimbo4350 deleted the fix/cip159-deposit-view branch October 22, 2026 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants