Repository navigation
Release upload signed tags - #1471
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Cleanup skips failed releases and can delete pre-existing branches that the run did not create.
2 open findings
What changed in this PR
Automates the CI-branch workaround so Hydra builds annotated release tags by commit.
Changes:
- Pushes annotated-tag commits to a
ci/branch. - Counts unfinished Hydra checks as pending.
- Deletes the CI branch after release publication.
| File | Description |
|---|---|
.github/workflows/release-upload.yml |
Adds branch creation, pending-check handling, and post-release cleanup. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
carbolymer
approved these changes
Oct 16, 2026
Jimbo4350
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
GHA was failing to fetch and thus upload artefacts to the release when releasing, because Hydra would report on the tag instead of the commit, and the GHA tag didn't see it. So it was necessary to create branch
ci/...to trigger Hydra on the actual commit.This PR automates the creation and later deletion of the branch so that Hydra builds it.
How to trust this PR
We won't really know for sure until next release. But the changes are small. I did test that creating the
ci/...branch works as a solution.Checklist
.changes/