Repository navigation
Remove script validity flags from Dijkstra transaction builders - #1474
Merged
Merged
Conversation
Jimbo4350
marked this pull request as ready for review
October 16, 2026 17:39
Jimbo4350
requested review from
carbolymer,
disassembler,
kevinhammond and
palas
as code owners
October 16, 2026 17:39
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused parser change consistently applies the intended era restriction, with matching regression coverage and help updates.
0 open findings
What changed in this PR
Prepares Dijkstra transaction builders for CIP-0167 by removing author-supplied script validity flags, while preserving Conway/latest behavior.
Changes:
- Reject both validity flags across all three Dijkstra builders.
- Add regression coverage and update help snapshots.
- Document the breaking CLI change.
| File | Description |
|---|---|
cardano-cli/test/cardano-cli-test/Test/Cli/Transaction/Build.hs |
Tests Dijkstra rejection and Conway/latest help. |
cardano-cli/test/cardano-cli-golden/files/golden/help/dijkstra_transaction_build.cli |
Removes validity flags from build help. |
cardano-cli/test/cardano-cli-golden/files/golden/help/dijkstra_transaction_build-raw.cli |
Removes validity flags from build-raw help. |
cardano-cli/test/cardano-cli-golden/files/golden/help/dijkstra_transaction_build-estimate.cli |
Removes validity flags from build-estimate help. |
cardano-cli/test/cardano-cli-golden/files/golden/help.cli |
Updates combined help snapshot. |
cardano-cli/src/Cardano/CLI/EraBased/Transaction/Option.hs |
Gates validity options by era across all builders. |
.changes/20261016_dijkstra_script_validity_flags.yml |
Records the breaking option removal. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
palas
approved these changes
Oct 16, 2026
palas
left a comment
palas
left a comment
Contributor
There was a problem hiding this comment.
It all looks correct to me 👍
| ] | ||
| pScriptValidity :: Exp.Era era -> Parser (Maybe ScriptValidity) | ||
| pScriptValidity era' = case era' of | ||
| Exp.DijkstraEra -> pure Nothing |
Contributor
There was a problem hiding this comment.
Would be good to have a comment that points at CIP-0167
Jimbo4350
force-pushed
the
fix/dijkstra-script-validity-flags
branch
from
October 16, 2026 18:19
7255582 to
344f24b
Compare
Jimbo4350
enabled auto-merge
October 16, 2026 18:20
1 of 17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Dijkstra transaction builders still exposed
--script-validand--script-invalid, which let the transaction author supply the validity assertion that CIP-0167 removes from standalone transactions. Reject both options for Dijkstratransaction build,build-raw, andbuild-estimate, and remove them from command help. Conway and the currentlatestalias retain both options.This is the CLI option change in preparation for CIP-0167. Transaction serialization and any replacement Node-to-Client submission parameter remain dependency/protocol work.
How to trust this PR
cabal build all --enable-testspassed with GHC 9.12.4.CARDANO_CLI="$(cabal list-bin exe:cardano-cli)" cabal test all --enable-tests --test-show-details=directpassed: 827 golden tests and 121 functional tests.git diff --checkpassed. Checks were run directly because the local pre-commit hook references a missing Nix interpreter.Checklist
.changes/