Repository navigation
Replace manual node config checking with a call to readNodeConfig - #1475
Merged
Merged
Conversation
palas
requested review from
a team,
Jimbo4350,
carbolymer,
disassembler and
kevinhammond
as code owners
October 16, 2026 18:50
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The unreleased API pin and platform-specific toolchain workarounds need cross-platform CI confirmation and human review.
0 open findings
What changed in this PR
Replaces manual node configuration checks with cardano-api’s readNodeConfig, supporting the new configuration format and stricter genesis validation.
Changes:
- Delegates validation and updates error reporting.
- Refreshes genesis fixtures, assertions, and breaking-change documentation.
- Updates dependencies and adds macOS and Windows build workarounds.
| File | Description |
|---|---|
flake.nix |
Adds Windows C runtime linking workaround. |
flake.lock |
Updates the package repository pin. |
cardano-cli/test/cardano-cli-test/Test/Cli/CheckNodeConfiguration.hs |
Updates expected validation errors. |
cardano-cli/test/cardano-cli-test/files/input/check-node-configuration/node-config.yaml |
Updates Conway genesis hash. |
cardano-cli/test/cardano-cli-test/files/input/check-node-configuration/node-config.json |
Updates hash and removes obsolete configuration flag. |
cardano-cli/test/cardano-cli-test/files/input/check-node-configuration/genesis.conway.spec.json |
Replaces invalid fixture with mainnet genesis. |
cardano-cli/src/Cardano/CLI/Type/Error/DebugCmdError.hs |
Introduces configuration-reading error. |
cardano-cli/src/Cardano/CLI/EraIndependent/Debug/CheckNodeConfiguration/Run.hs |
Delegates checks to readNodeConfig. |
cabal.project |
Updates package index and temporarily pins API source. |
.github/workflows/haskell.yml |
Aligns macOS SDK with Xcode toolchain. |
.changes/20261015_022558_cardano-cli_palas_check_node_configuration_cardano_config.yml |
Documents breaking validation changes. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
4 tasks done
carbolymer
approved these changes
Oct 19, 2026
3 of 5 tasks
johnalotoski
pushed a commit
to IntersectMBO/cardano-node
that referenced
this pull request
Oct 22, 2026
cardano-api 11.10.0.0 carries the readNodeConfig rewrite that reads both the flat and the cardano-config enveloped formats, so it comes from CHaP and the local bounds move to ^>= 11.10. cardano-cli's matching change is still open as IntersectMBO/cardano-cli#1475, so it stays a source-repository-package until that releases. plutus-scripts-bench caps cardano-api at ^>=11.8 and is not ours to edit, hence the allow-newer.
johnalotoski
pushed a commit
to IntersectMBO/cardano-node
that referenced
this pull request
Oct 22, 2026
cardano-api 11.10.0.0 carries the readNodeConfig rewrite that reads both the flat and the cardano-config enveloped formats, so it comes from CHaP and the local bounds move to ^>= 11.10. cardano-cli's matching change is still open as IntersectMBO/cardano-cli#1475, so it stays a source-repository-package until that releases. plutus-scripts-bench caps cardano-api at ^>=11.8 and is not ours to edit, hence the allow-newer.
johnalotoski
pushed a commit
to IntersectMBO/cardano-node
that referenced
this pull request
Oct 22, 2026
cardano-api 11.10.0.0 carries the readNodeConfig rewrite that reads both the flat and the cardano-config enveloped formats, so it comes from CHaP and the local bounds move to ^>= 11.10. cardano-cli's matching change is still open as IntersectMBO/cardano-cli#1475, so it stays a source-repository-package until that releases. plutus-scripts-bench caps cardano-api at ^>=11.8 and is not ours to edit, hence the allow-newer.
…d fix the macOS and Windows builds
palas
force-pushed
the
config-dedup
branch
2 times, most recently
from
October 23, 2026 00:00
c2485e2 to
42b515e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This PR replaces the manual node config checking with a call to
readNodeConfigfromcardano-api.Build on this PR: IntersectMBO/cardano-api#1379
How to trust this PR
It is quite straightforward, just a lot of code replaced with the call to
readNodeConfig.Nevertheless there are a couple of side-effects of the change:
cardano-configformat are accepted.DebugNodeConfigWrongGenesisHashCmdErroris replaced byDebugNodeConfigReadCmdError.In addition to that, the PR includes a couple of fixes to get the CI to work in the different platforms.
Checklist
.changes/