Skip to content

Drop prefilled tasks on cancel - #1134

Open
Mrmaxmeier wants to merge 2 commits into
It4innovations:mainfrom
Mrmaxmeier:fix-cancel-prefilled
Open

Mrmaxmeier wants to merge 2 commits into
It4innovations:mainfrom
Mrmaxmeier:fix-cancel-prefilled

Conversation

@Mrmaxmeier

Copy link
Copy Markdown

This resolves #1133:

$ ./repro.sh | rtss
   1.52s    1.52s | == hyperqueue 0.26.2-dev
   1.52s    0.3ms | == submit A
   1.72s  208.5ms | started: A1 A2 A3 A4
   2.02s  297.4ms | == cancel A
   2.03s    3.9ms | == submit B
   2.11s   84.4ms | started: B1 B2 B3 B4 B5 B6 B7 B8
   2.11s    4.3ms | == B finished
   2.12s    exit code: 0

Thanks!

A cancelled task that was prefilled on a worker stayed in
prefilled_tasks and was started later by prefill_loop.

Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
Scan prefilled tasks once per CancelTasks message and log ids that
are neither running nor prefilled.

Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cancelled prefilled tasks still start on the worker

1 participant