Make release workflow tag-driven only - #91
Open
JansenDevelopment wants to merge 2 commits into
Open
JansenDevelopment wants to merge 2 commits into
JansenDevelopment wants to merge 2 commits into
Conversation
Drop the bootstrap branch trigger now that the workflow lives on develop. Releases are cut by pushing a v* tag (or manual workflow_dispatch). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ro82CB9Y3Sdq8b7Suk9Kys
Expose each actuator device's heat/cool/both role as a native select entity, backed by a new smart_climate.set_device_role service and async_set_device_role coordinator method. Roles persist to the device's source of truth (config subentry when present, else the entry.data devices list) and re-drive the control loop without a full reload. Covered by tests/test_device_role.py. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ro82CB9Y3Sdq8b7Suk9Kys
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the bootstrap branch trigger from the release workflow now that it lives on
develop.The
claude/release-latest-commit-**push trigger was only needed to create the initial v1.1 release from within Actions (this session couldn't push tags or create releases directly). With the workflow now ondevelop, that trigger is a footgun — any push to such a branch would attempt to cut a release.Change
.github/workflows/release.ymlnow triggers on:pushof av*tag — the standard release pathworkflow_dispatch— manual fallback (derives the tag frommanifest.json)The job body is unchanged and remains idempotent (skips tag/release creation if they already exist).
How to cut a release going forward
Push a version tag, e.g.
git tag v1.2 && git push origin v1.2, or run the workflow manually from the Actions tab.🤖 Generated with Claude Code
Generated by Claude Code