Skip to content
This repository was archived by the owner on Mar 29, 2026. It is now read-only.

fix, ci: general code improvements, removed some ci runners. - #15

Merged
Jaskowicz1 merged 8 commits into
mainfrom
generic_improvements
Jan 5, 2026
Merged

fix, ci: general code improvements, removed some ci runners.#15
Jaskowicz1 merged 8 commits into
mainfrom
generic_improvements

Conversation

@Jaskowicz1

@Jaskowicz1 Jaskowicz1 commented Jan 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Owner

This PR:

  • Adds general code improvements (removed missing spaces, adds const in some places, moved read_packet_size to utilities, started using constexpr numbers from utilities).
  • Makes packet_size no longer converted to size_t (might fix Responses are empty after 2nd command send #11, this PR doesn't intend to fix this).
  • Removed some warnings on windows.
  • Added more Unit Tests (Invalid client setups are now tested).
  • Removed some ci runners since GitHub no longer supports Ubuntu 20.04 LTS and a lot of them just were not needed anymore.

@Jaskowicz1
Jaskowicz1 merged commit 112a738 into main Jan 5, 2026
28 of 30 checks passed
@Jaskowicz1
Jaskowicz1 deleted the generic_improvements branch January 8, 2026 21:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Responses are empty after 2nd command send

1 participant

@Jaskowicz1