refactor(Tests): Add variables to deal with nodiscard warnings - #845
Open
MathewBensonCode wants to merge 1 commit into
Open
MathewBensonCode wants to merge 1 commit into
MathewBensonCode wants to merge 1 commit into
Conversation
MathewBensonCode
commented
Sep 30, 2026
MathewBensonCode
commented
Contributor
- The variables are unused but existing to comply with the [[nodiscard]] attribute
- Convention is to use and underscore, add a relevant name where there is more than one
- The variables are unused but existing to comply with the [[nodiscard]] attribute - Convention is to use and underscore, add a relevant name where there is more than one
MathewBensonCode
force-pushed
the
nodiscard_warnings
branch
from
September 30, 2026 19:08
468f1b6 to
4636d3f
Compare
JeanPhilippeKernel
self-requested a review
October 1, 2026 08:00
JeanPhilippeKernel
added
area-linux
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.