Repository navigation
chore(deps): drop the unused datasets dependency - #10
Merged
Jeomon merged 2 commits intoOct 27, 2026
Merged
Conversation
datasets is declared as a runtime dependency but nothing in the package imports it. A search over the whole tree - package, tests and scripts - turns up no reference to it. It is not a small dependency either: it pulls in pyarrow, pandas, dill, fsspec and multiprocess. Installing windows-use without it is 421 MB against 579 MB with it, and the full test suite still passes. If a dataset backed feature shows up later, the dependency can be added back with the feature that needs it.
Picks up the removal of the datasets chain (pyarrow, pandas, numpy, dill, multiprocess and friends) and also drops the stale neonize entries, which have been left over since that dependency was removed from pyproject in 456d6d7.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
datasetsis declared as a runtime dependency, but nothing in the package imports it. A search over the whole tree - package, tests and scripts - turns up no reference to it.It is not a small dependency either. It pulls in pyarrow, pandas, numpy, dill and multiprocess, and it is the only reason those end up on the install path.
Measured
datasetsdatasetsBoth numbers come from a clean
uv venv+uv sync --extra devon the same machine.Verification
pytest tests/unit/ -v --tb=short- 109 passed, 5 skippedpytest tests/- 122 passed, 5 skippedimport windows_useworkspython -m windows_use.cli --helpworksdatasets,pyarrowandpandasare confirmed absent from the environmentThe lockfile
uv.lockis regenerated in the same change. Besides the datasets chain this also drops the staleneonizeentries, which have been sitting in the lock since that dependency was removed frompyproject.tomlin 456d6d7.Note
If a dataset backed feature shows up later, the dependency can be added back together with the feature that needs it.
The test job is currently red on
mainfor an unrelated reason - the mistral provider import, see #12.