Repository navigation
Fix iOS keyboard insets for floating keyboard - #3576
Open
Vendula Švastalová (svastven) wants to merge 2 commits into
Open
Vendula Švastalová (svastven) wants to merge 2 commits into
Vendula Švastalová (svastven) wants to merge 2 commits into
Conversation
Vendula Švastalová (svastven)
requested review from
Andrei Salavei (ASalavei) and
Vladimir Mazunin (mazunin-v-jb)
November 5, 2026 16:31
| } | ||
|
|
||
| private fun isUndockedKeyboard(frame: CValue<CGRect>, screen: UIScreen): Boolean = | ||
| CGRectGetMaxY(frame) < CGRectGetMaxY(screen.bounds) |
There was a problem hiding this comment.
Would it worth checking width of the keyboard as well?
Also, since we're working with doubles, could you please compare values with tolerance here?
Vendula Švastalová (svastven)
force-pushed
the
svastven/CMP-11095
branch
from
November 5, 2026 19:23
42b2771 to
d710d32
Compare
Vladimir Mazunin (mazunin-v-jb)
approved these changes
Nov 11, 2026
Andrei Salavei (ASalavei)
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
willHideinterrupts an in progress keyboard to shortcut-bar animation, continue from the current visible animation position instead of snapping to the shortcut bar firstFixes CMP-11095 iOS: a floating (undocked) iPad keyboard is treated as docked — WindowInsets.ime reports the distance from its top edge to the bottom of the screen
Testing
willHide, checking the bottom content continues animating without a jumpRelease Notes
Fixes - iOS