Refactor/source registry - #32
Merged
Merged
Conversation
The roadmap adds model-provider APIs, token plans and local agent usage on top of the public clouds. Each one would have meant editing the same 48 `CloudProvider::` sites across seven files, so the enum has to go before any of that work starts. A source is now a row in `registry::SOURCES` carrying its labels, its default region, what it reports, and a function pointer that builds its client. Callers ask the descriptor what a source can do instead of who it is: the dashboard lists DeepSeek under balances because its reporting is `Snapshot`, not because it is named DeepSeek, and it skips the trend request because `trend_window_days()` is None rather than because of a `matches!` on the variant. Adding a source is a table entry plus a parser. Behavior is otherwise unchanged, with two exceptions: - An account whose stored source id is not registered used to be read back as AWS, which would sign its requests with the wrong scheme and file the resulting costs under the wrong provider. It is now skipped with a warning. - Switching the add-account form to a source with no region used to leave the previous source's region in the field, so a DeepSeek account could be saved carrying "us-east-1". The field is now cleared. Also drops `NewAccountForm`, which was dead and existed only to hold a `CloudProvider`, and adds a CI step for `cargo test` — three tests already existed and were never run. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
- Add DeepSeek to hero, stats, features, and FAQ to match the README - Add macOS Intel download button and fix .zip asset names - Add install notes (SmartScreen, chmod/xattr) to the download section - Show the app screenshot below the hero - Turn the FAQ into native <details> accordions and add an IAM permissions entry linking to docs/policies.md - Add OG meta tags, theme-color, and an inline SVG favicon - Rework buttons (2px borders, translateY hover), unify card styling, add scroll-margin-top, skip link, and <main> landmark
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.