Validate embedded viewport package - #1
Merged
Merged
Conversation
Resolve, format, analyze, and test `quiet_viewport` alongside the app while excluding it from the root analyzer. Document its separate validation context.
There was a problem hiding this comment.
🟡 Changes recommended
The formatting script now performs dependency resolution (side effects) and the contributor documentation should be updated to accurately reflect the new script behavior.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the project’s validation pipeline to treat the embedded packages/quiet_viewport as a separately validated Dart package while keeping it excluded from the root Flutter analyzer configuration.
Changes:
- Add dependency resolution (
flutter pub get+dart pub getforquiet_viewport) as an explicit step in the toolchain scripts. - Extend
validate.shto analyze and run tests forpackages/quiet_viewportin its own dependency context. - Exclude
packages/**from the root analyzer to prevent the embedded package from being analyzed as part of the app’s source set.
File summaries
| File | Description |
|---|---|
| docs/09-contributing/02-testing-and-validation.md | Updates contributor docs to mention validating quiet_viewport separately. |
| bin/tools/validate.sh | Adds explicit dependency resolution and runs dart analyze/dart test in packages/quiet_viewport. |
| bin/tools/beautify.sh | Adds explicit dependency resolution before formatting. |
| bin/tools/_shared.sh | Introduces QUIET_VIEWPORT_ROOT, expands DART_PATHS, and adds resolve_dependencies. |
| analysis_options.yaml | Excludes packages/** from the root analyzer. |
Review details
- Files reviewed: 2/5 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: JosephGabito <81974552+JosephGabito@users.noreply.github.com>
JosephGabito
added a commit
that referenced
this pull request
Aug 28, 2026
Validate embedded viewport package
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve, format, analyze, and test
quiet_viewportalongside the app while excluding it from the root analyzer. Document its separate validation context.