Skip to content

Use ProjectTo in multiarg + - #783

Merged
devmotion merged 6 commits into
mainfrom
ox/proj_in_add
Oct 29, 2026
Merged

devmotion merged 6 commits into
mainfrom
ox/proj_in_add

Conversation

@oxinabox

@oxinabox oxinabox commented Feb 9, 2024 •

Copy link
Copy Markdown
Member

I believe the reshape(..., axes(a)) was basically a early stand before we had the more fully features ProjectTo code.
Came up when reviewing #782

@oxinabox
oxinabox requested a review from mcabbott February 9, 2024 10:51
@mcabbott

mcabbott commented Feb 9, 2024

Copy link
Copy Markdown
Member

Duplicate of #578 . That one has some evil tests, which should perhaps be copied here... do they now pass?

Comment thread test/rulesets/Base/arraymath.jl Outdated
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
mcabbott
mcabbott previously approved these changes Feb 20, 2024
@mcabbott
mcabbott dismissed their stale review February 20, 2024 15:02

didn't see that tests failed

@codecov

codecov Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.63%. Comparing base (bbb9757) to head (f1c4614).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #783   +/-   ##
=======================================
  Coverage   96.63%   96.63%           
=======================================
  Files          28       28           
  Lines        3594     3594           
=======================================
  Hits         3473     3473           
  Misses        121      121           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions Bot removed the needs version bump Version needs to be incremented or set to -DEV in Project.toml label Oct 29, 2026
@devmotion
devmotion merged commit 2516ebf into main Oct 29, 2026
11 checks passed
@devmotion
devmotion deleted the ox/proj_in_add branch October 29, 2026 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants