Repository navigation
Remove documentation previews without rewriting gh-pages, and link them - #34
Merged
Merged
Conversation
The cleanup workflow squashed gh-pages into a single commit and force-pushed it every time a pull request closed, which races with documentation deploys pushing to the same branch. Replace it with Documenter's ClearPreview.yml, which only deletes the preview.
Documenter only reports the preview as a commit status, which is easy to miss. Comment once with a link to it on pull requests that change the documentation.
maleadt
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The preview cleanup squashed gh-pages into a single commit and force-pushed it whenever a pull request closed, which races with documentation deploys that push to gh-pages at the same time. This replaces it with Documenter's ClearPreview.yml, the same workflow as in JuliaGPU/Metal.jl#1081 and JuliaGPU/CUDA.jl#3432: it deletes
previews/PR<n>with a regular commit, and skips pull requests from forks.It also comments once with a link to the preview on pull requests from this repository that change
docs/, as Documenter only reports it as a commit status, which is easy to miss.