Skip to content

Free resized buffers with release, not free #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maleadt merged 1 commit into from
Oct 14, 2026
Merged

Free resized buffers with release, not free #684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/array.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -652,7 +652,7 @@ function Base.resize!(a::oneVector{T}, n::Integer) where {T}
unsafe_copyto!(ctx, dev, ptr, pointer(a), m)
end
new_data = DataRef(buf) do buf
free(buf)
release(buf)
end
unsafe_free!(a)

Expand Down
16 changes: 16 additions & 0 deletions test/array.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,22 @@ end
@test length(b) == 0
resize!(b, 1)
@test length(b) == 1

# resized buffers are released through the pool, like freshly allocated ones
c = oneArray{Float32}(undef, 4)
resize!(c, 0)
oneAPI.unsafe_free!(c)

GC.enable(false)
try
d = oneArray{Float32}(undef, 1024)
before = oneAPI._allocated_bytes[]
resize!(d, 1 << 20)
oneAPI.unsafe_free!(d)
@test oneAPI._allocated_bytes[] == before - sizeof(Float32) * 1024
finally
GC.enable(true)
end
end

# Reductions and scans come from GPUArrays (AcceleratedKernels). oneAPI used to work around
Expand Down
Loading