Repository navigation
Bump NEO to 26.35, fix BFloat16 detection - #701
Merged
Merged
Conversation
The SPV_KHR_bfloat16 extension was declared whenever the driver advertised ZE_extension_bfloat16_conversions. That extension only covers the conversion instructions of SPV_INTEL_bfloat16_conversion, and NEO 26.35 advertises it on all platforms, including Xe-LP and Meteor Lake, where IGC rejects SPV_KHR_bfloat16 by exiting the process (status 10). Level Zero can't tell which SPIR-V extensions IGC accepts, so mirror IGC's platform table: graphics IP 12.55 and up, except Meteor Lake's 12.70 and 12.71. This is a workaround for intel/intel-graphics-compiler#452. Kernels now only see bfloat values where the extension is declared, which leaves the partial bfloat-to-i16 lowering unused; remove it. On other devices, bfloat kernels fail with an InvalidIRError. BFloat16 arrays are still gated on the conversions extension.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #701 +/- ##
==========================================
+ Coverage 82.34% 82.99% +0.65%
==========================================
Files 52 51 -1
Lines 4417 4240 -177
==========================================
- Hits 3637 3519 -118
+ Misses 780 721 -59 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.