Repository navigation
Test appending a batch to an idle stream after host syncs - #709
Merged
Merged
Conversation
Contributor
|
Your PR requires formatting changes to meet the project's style guidelines. Click here to view the suggested changes.diff --git a/test/execution.jl b/test/execution.jl
index 78bec08..b965fc5 100644
--- a/test/execution.jl
+++ b/test/execution.jl
@@ -1024,7 +1024,7 @@ end
end
oneAPI.mkl_boundary!()
end
- @test Array(x) == fill(8000f0, 1024)
+ @test Array(x) == fill(8000.0f0, 1024)
# a failed submission is reported until the stream is synchronized
@test fetch(@async begin |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #709 +/- ##
==========================================
+ Coverage 82.40% 83.44% +1.04%
==========================================
Files 52 51 -1
Lines 4415 4253 -162
==========================================
- Hits 3638 3549 -89
+ Misses 777 704 -73 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
When a batch is appended to an in-order immediate list with nothing pending, NEO dispatches the regular list's own command buffer as the batch buffer. NEO 26.35 then wrote a pending UC tag update into that full buffer and aborted in LinearStream::getSpace (intel/compute-runtime#1027), which crashed the test suite sporadically since launches are batched. Fixed in NEO_jll 26.35.39758+2.
maleadt
force-pushed
the
tb/batch-append-idle
branch
from
October 18, 2026 13:07
86d7ee9 to
33e6dfc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a regression test for an abort in NEO 26.35 (intel/compute-runtime#1027), which made the test suite crash sporadically since launches are batched (#693), e.g. in the fft tests on #707:
When a batch is appended to an in-order immediate list with nothing pending (after
mkl_boundary!drained it, for example), NEO dispatches the regular list's own command buffer as the batch buffer. If the driver recycled its ring buffer just before, it wrote a pending tag update into that full buffer and aborted. NEO_jll 26.35.39758+2 (JuliaPackaging/Yggdrasil#15175) carries the fix; our=26.35.39758compat already picks up that build.The test aborts in its first iteration with NEO_jll +1 and passes with +2, where it takes under a second. With +2, the
execution,fftandlevel-zerotests pass on Tiger Lake. The LTS driver (25.18) predates the code involved and isn't affected.