Skip to content

ALCF CI: keep labeling a PR from cancelling its LTS run - #722

Closed
maleadt wants to merge 1 commit into
mainfrom
tb/alcf-concurrency
Closed

maleadt wants to merge 1 commit into
mainfrom
tb/alcf-concurrency

Conversation

@maleadt

@maleadt maleadt commented Oct 19, 2026

Copy link
Copy Markdown
Member

Labeling a pull request triggers a pull_request_target run of the ALCF workflow. That run joined the workflow-level concurrency group alcf-<PR> and cancelled the pull_request run waiting for the GitLab pipeline, and only then skipped its own job, since only fork PRs act on a label. Same-repo PRs that get a label, including through gh pr create --label, thus never got an LTS result. Their check shows as failed with "Canceling since a higher priority waiting request for alcf- exists". This is currently the case for #713, #716 and #720.

Moving the concurrency group to the job means only runs whose job actually runs join it. Since pull_request_target runs use the workflow from main, this can only be verified after merging, by labeling a PR.

Labeling a pull request triggers a pull_request_target run, which joined the workflow's
concurrency group and cancelled the run waiting for the GitLab pipeline, before its own
job was skipped (only fork PRs act on a label). Same-repo PRs that were labeled thus never
got an LTS result. Taking the group on the job only lets runs that do something join it.
@codecov

codecov Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.48%. Comparing base (a0adaa1) to head (0cde819).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #722      +/-   ##
==========================================
+ Coverage   83.13%   83.48%   +0.35%     
==========================================
  Files          52       51       -1     
  Lines        4376     4263     -113     
==========================================
- Hits         3638     3559      -79     
+ Misses        738      704      -34     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@maleadt

maleadt commented Oct 20, 2026

Copy link
Copy Markdown
Member Author

#726

@maleadt maleadt closed this Oct 20, 2026
michel2323 added a commit that referenced this pull request Oct 20, 2026
#726)

alcf.yml no longer keeps a runner polling the Aurora pipeline for hours. It
starts the pipeline as before and sets the commit status
`ALCF / LTS stack (Aurora)` to pending; alcf-report.yml (restored) sets the
result when GitLab's pipeline webhook dispatches it.

Jobs that fail without running their script (no Aurora runner online,
stuck_pending_no_matching_runners; a PBS job the runner lost,
no_updates_running; runner errors) say nothing about the change. Such a
pipeline is retried once with a fresh pipeline, and reported as an error that
names the infrastructure failure if that fails too, instead of as a test
failure.

The concurrency group moves to the job, so that a labeled same-repo PR no
longer cancels its own run (supersedes #722).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant