Repository navigation
Raise a clear error when passing CPU arrays to kernels - #723
Merged
Merged
Conversation
Mixing a oneArray with an Array in a broadcast, or passing an Array to `@oneapi`, only failed in the compiler's argument validation, which dumps the full argument type and its non-isbits fields. Reject Arrays during argument conversion instead, with a message pointing at `oneArray`.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #723 +/- ##
==========================================
+ Coverage 83.13% 83.48% +0.35%
==========================================
Files 52 51 -1
Lines 4376 4264 -112
==========================================
- Hits 3638 3560 -78
+ Misses 738 704 -34 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mixing a
oneArraywith anArrayin a broadcast (oneArray(x) .+ y), or passing anArrayto@oneapi, used to fail in GPUCompiler's argument validation, which prints the wholeBroadcastedtype and walks its non-isbits fields. Arrays are now rejected while converting kernel arguments, before compilation:The compiler already rejected every non-isbits argument, used or not, so this only changes the error. Adapt recurses into wrappers, so views, adjoints,
Refs and captured arrays get the same message.Port of JuliaGPU/Metal.jl#1077 (JuliaGPU/Metal.jl#212).