Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #597 +/- ##
==========================================
+ Coverage 98.84% 98.99% +0.14%
==========================================
Files 10 10
Lines 1303 1391 +88
==========================================
+ Hits 1288 1377 +89
+ Misses 15 14 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
kimikage
force-pushed
the
distcolor_candidates
branch
4 times, most recently
from
October 14, 2026 04:24
587da13 to
47ebf76
Compare
kimikage
force-pushed
the
distcolor_candidates
branch
from
October 14, 2026 09:50
47ebf76 to
b426f9b
Compare
kimikage
marked this pull request as ready for review
October 15, 2026 06:16
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #573
This explicitly throws an error when there are not enough candidate colors for the requested number of colors.
Strictly speaking, this is a breaking change, but it is safer than returning invalid colors.
Also, to ensure consistency with the
candidates, this explicitly converts theseedtoLab{Float32}before applyingtransform.