Skip to content

Add the candidates keyword argument to distinguishable_colors - #597

Open
kimikage wants to merge 1 commit into
JuliaGraphics:masterfrom
kimikage:distcolor_candidates
Open

kimikage wants to merge 1 commit into
JuliaGraphics:masterfrom
kimikage:distcolor_candidates

Conversation

@kimikage

@kimikage kimikage commented Oct 13, 2026 •

Copy link
Copy Markdown
Collaborator

Closes #573

This explicitly throws an error when there are not enough candidate colors for the requested number of colors.
Strictly speaking, this is a breaking change, but it is safer than returning invalid colors.

Also, to ensure consistency with the candidates, this explicitly converts the seed to Lab{Float32} before applying transform.

@codecov

codecov Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.99%. Comparing base (38fa1b3) to head (b426f9b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #597      +/-   ##
==========================================
+ Coverage   98.84%   98.99%   +0.14%     
==========================================
  Files          10       10              
  Lines        1303     1391      +88     
==========================================
+ Hits         1288     1377      +89     
+ Misses         15       14       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kimikage
kimikage force-pushed the distcolor_candidates branch 4 times, most recently from 587da13 to 47ebf76 Compare October 14, 2026 04:24
@kimikage
kimikage force-pushed the distcolor_candidates branch from 47ebf76 to b426f9b Compare October 14, 2026 09:50
@kimikage
kimikage marked this pull request as ready for review October 15, 2026 06:16

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

make _distinguishable_colors public ?

1 participant