Repository navigation
Draw sprand column by column again for 2^63 or more entries - #1143
Open
ViralBShah wants to merge 2 commits into
Open
ViralBShah wants to merge 2 commits into
ViralBShah wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1143 +/- ##
=======================================
Coverage 94.67% 94.68%
=======================================
Files 16 16
Lines 10422 10437 +15
=======================================
+ Hits 9867 9882 +15
Misses 555 555 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1137 made
sprandthrow for a matrix of 2^63 or more entries, to save compile time. That rejects calls with a correct and affordable answer, including density 0, and it reachedrelease-1.14through #1136.Before (
main)After
This restores the branch of #1128 that draws the rows of each column separately, since an
Intcannot index them*nentries. This keeps #1137'swidelengthandsizehint!changes, which are most of its saving. Invalid arguments throwArgumentErrorbefore the size is looked at again, andtest/issues.jlnow pins that order.The branch is not free. The TTFX workload, median of 16 fresh processes interleaved and pinned to one CPU of an AMD EPYC 9354, with the same
--trace-compilecount of 11 on both:mainThat is 2.7% cold and 1.5% warm, kept because the alternative is a throw on working code. A matrix of this shape still needs one column pointer per column, so
sprand(2^40, 2^40, 0.0)runs out of memory likespzeros(2^40, 2^40).Backport candidate for 1.14, which carries the throw.
Left out: measuring 32-bit builds, where
m*noverflows at 2^31 entries, so that this branch serves ordinary sizes there.🤖 Generated with Claude Code