Repository navigation
Conversation
|
@Ottones Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes the event outbox poller so that events are delivered in per-vault order. Previously the poller ordered globally by
createdAt, which allowed events from different vaults to interleave and let a slow webhook for one vault delay another vault's events — causing consumers that trackvault.versionto observe out-of-order state (e.g.version 5beforeversion 4).The fix adds a monotonic
sequencecolumn scoped to eachvaultId, orders polling byvaultId, createdAt, and asserts per-vault ordering in tests.Related Issue
Changes
🗂️ Outbox schema
[MODIFY]
backend/prisma/schema.prismasequence(monotonic pervaultId) to the event outbox model, with a unique constraint on(vaultId, sequence)and an index supportingvaultId, createdAtpolling.[ADD]
backend/prisma/migrations/20260824204600_add_event_outbox/migration.sqlsequencecolumn, backfilling existing rows pervaultId, and creating the per-vault unique + ordering indexes.📤 Outbox writer
backend/src/eventOutbox.tssequencewhen enqueuing an event, so eachvaultIdgets a strictly incrementing sequence.🔁 Poller
backend/src/jobs/outboxPoller.tsvaultId, createdAt(andsequence) so events for a given vault are processed in enqueue order and are not reordered by retries or interleaving across vaults.✅ Tests
backend/src/__tests__/eventOutbox.test.tssequenceincrements by 1 pervaultId.Verification Results
vaultId, createdAtor uses per-vault queue withFOR UPDATE SKIP LOCKEDpartitioned byvaultIdvaultId, createdAt(withsequence)sequencemonotonic pervaultIdcolumn to outbox and assertsequenceincrements by 1 per vault in testsequencecolumn added; test asserts +1 pervaultIdCloses #1447