Repository navigation
Conversation
|
@taiwo722-blip Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes a runtime fragility where
prisma.eventOutboxresolved toundefinedin certain execution paths of the outbox relayer, causingCannot read properties of undefined (reading 'create')errors during governance test runs. The root cause was inconsistent Prisma client initialization/import paths across the backend modules, which allowed the relayer to reference an uninitialized or differently-instantiated client under load. This change consolidates client initialization and ensureseventOutbox.tsalways resolves the shared, initialized Prisma client.Related Issue
Changes
🔧 Prisma Client Initialization
[MODIFY]
backend/src/prisma.ts[MODIFY]
backend/src/prismaClient.tsprisma.ts, removing the divergent initialization path that could yield an undefinedeventOutboxdelegate.[MODIFY]
backend/src/database.ts📤 Outbox Relayer
backend/src/eventOutbox.tseventOutboxtoundefined, soprisma.eventOutbox.createis always defined when writing events.Verification Results
The governance test path that previously logged
"Failed to write event to outbox"withCannot read properties of undefined (reading 'create')now resolvesprisma.eventOutbox.createcorrectly, since all modules share the same initialized client.prisma.eventOutbox.createis defined in all runtime pathsprisma.ts,prismaClient.ts,database.ts, andeventOutbox.tsCannot read properties of undefined (reading 'create')eventOutbox.test.tscontinues to passCloses #1370