This repository was archived by the owner on Sep 24, 2023. It is now read-only.
Disabled create new documents while offline - #45
Open
renatofilho wants to merge 1 commit into
Open
renatofilho wants to merge 1 commit into
renatofilho wants to merge 1 commit into
Conversation
dfaure-kdab
suggested changes
Nov 30, 2017
dfaure-kdab
left a comment
dfaure-kdab
left a comment
Member
There was a problem hiding this comment.
Instead of setting this up in all three Details classes, why not do it directly in Page::createItemEditWidget()?
i.e. instead of Page -> SimpleItemEditWidget -> Details,
just connect directly Page -> Details.
(not that intermediaries are a problem, but rather in this case to factorize code, AFAICS a single connect will be enough)
renatofilho
force-pushed
the
disable-create-doc-while-offline
branch
from
December 11, 2017 17:57
7a3d4c1 to
54dd570
Compare
dfaure-kdab
reviewed
Jan 19, 2018
|
|
||
| void DocumentsWindow::setCreateNewEnabled(bool enabled) | ||
| { | ||
| ui->attachButton->setEnabled(enabled); |
Member
There was a problem hiding this comment.
I like when disabled widgets give a hint about why they're disabled, so that the user can know what to do to enable it.
In this case this would mean something like this:
if (!enabled)
ui->attachButton->setToolTip(i18n("Attaching new documents requires being online"));
else
ui->attachButton->setToolTip(QString());
dfaure-kdab
suggested changes
Jan 19, 2018
dfaure-kdab
left a comment
dfaure-kdab
left a comment
Member
There was a problem hiding this comment.
Looks good, just missing a tooltip.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 'Attach New Document' will be disabled while the app is running on offline mode.