Demo proposal: Set up a CI with linting and SonarCloud checks, week 2 - #2974
Open
williamnordwall wants to merge 4 commits into
Open
Demo proposal: Set up a CI with linting and SonarCloud checks, week 2#2974williamnordwall wants to merge 4 commits into
williamnordwall wants to merge 4 commits into
Conversation
Collaborator
|
The group folder should be inside a week folder ! |
Collaborator
|
Hi, the proposal sounds good. Please clarify what other issues you want to report. |
|
@frankreyesgarcia We've added some clarifications as recommended. Please let us know if you need more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assignment Proposal
Title
Setup automated linting and code checks with SonarCloud
Names and KTH ID
Deadline
Category
Description
We want to set up a GitHub Actions CI which runs linting on each PR to check for correct formatting.
The CI will also use SonarCloud to scan the code for code quality issues. These can be issues such as unused variables, functions with high complexity or having poor test coverage (<80%).
In the demo we will first show a functioning application. We will then demonstrate what happens if we push code that is poorly formatted or has one or more of the issues above that SonarCloud will find.
Relevance
Ensuring high code quality is an important part of DevOps.
Linting code to check for correct formatting helps with clarity, and using SonarCloud to check for code issues such as the ones mentioned above also improves the quality of the code.