Add multithread support for input validation #417 - #480
Open
gkreitz wants to merge 1 commit into
Open
Conversation
Tagl
approved these changes
Aug 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multithreading support for input validation (
-j nnow runs n test case validations in parallel).Adds a similar structure to
ResultsStorewhich keeps track of futures for input validation of each test case. I looked at extracting common functionality in a base class, but I don't think that ends up very clean (even if it does feel a bit silly to have one class per thing we want to queue up future work for, the call patterns end up different enough that it currently doesn't seem to generalize well).Fixes #417