Repository navigation
Fix shutdown cancellation and process waits under parallel load - #431
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Handle locally timed-out shutdown RPC cancellation without masking unexpected errors. Replace process polling with bounded synchronous and asynchronous exit waits, retaining forced termination and log cleanup. Add disposal regressions and repeated ten-host startup/shutdown coverage. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Remove InternalsVisibleTo and implementation-level disposal mocks. Exercise real host lifecycle scenarios through IApp and RemoteExecute, restore test-local Win32 declarations, and enforce the repository-wide API ban with BannedApiAnalyzers and RS0030 errors. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix teardown failures observed when running ten non-interactive UI tests concurrently in MaterialDesignInXAML/MaterialDesignInXamlToolkit#4103. The failing run reported 17 gRPC
Cancelledexceptions fromApp.DisposeAsyncafter test bodies and recorder success checks completed: https://github.com/MaterialDesignInXAML/MaterialDesignInXamlToolkit/actions/runs/39060871422/job/117478381849.WaitForExit/WaitForExitAsyncon the existing process instance. Retain forced termination and confirm exit with another bounded wait.App.StartRemote, lifecycle behavior throughIApp, and remote setup throughRemoteExecute. No friend assemblies, internal casts, reflection into implementation details, or transport mocks.Microsoft.CodeAnalysis.BannedApiAnalyzersto every project with a sharedBannedSymbols.txt, banningInternalsVisibleToAttributeas an RS0030 build error.The server's existing 500 ms delayed shutdown/protocol is unchanged. Toolkit window activation and its package reference are also unchanged; consuming a published fixed build remains separate work.
Validation
dotnet build XAMLTest.slnx -c Release: succeeded with no warnings or errors.dotnet test XAMLTest.Tests\XAMLTest.Tests.csproj -c Release --no-restore --filter FullyQualifiedName~AppDisposalTests --logger "console;verbosity=minimal": all 8 public-API cases passed.InternalsVisibleToattributes fail with RS0030. Probes were removed afterward.The former implementation-level mocked RPC tests were removed rather than bypassing the public API boundary. The public lifecycle tests do not claim deterministic coverage of individual transport exception branches.