Repository navigation
fix(web): restore go-to-today now-cue pulse on repeated t presses - #4475
Merged
Merged
Conversation
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Contributor
|
Boot bundle: 507.7 KB gzip (+0.0 KB vs main) |
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4473
What and why
PR #4468 moved the week header teach cue from a clipped box-shadow ring to text-only label pulses, but three gaps broke the no-op feedback Tyler saw on staging: label keyframes pulsed
inherit→accent while today is already accent (invisible), now-line keyframes zeroedbox-shadowagainst the inline paper rim, andnowCueActions.pulse()keptactive: truewithout remounting so CSS never restarted on repeatedt. This change also pulses when the now line is in view and scroll is near the teach target (not only within 2px), clamps scroll-to-now at zero for early morning, bumpspulseGenerationfor animation restarts, and adds Playwright coverage for repeated presses.Verify
Local:
bun test:web659 pass;bunx playwright test e2e/now-cue-pulse.spec.tspass;apps/calendar-webbun run build.tspass.VERDICT: PASS (web unit + targeted e2e; full verify --strict hit unrelated e2e/a11y flake in sandbox)