Repository navigation
refactor: drop the pass-through oauth state wrapper, dead apple decode, and a duplicated schedule literal - #4477
Merged
Merged
Conversation
…-today Four components each subscribed to the now-cue store twice and rebuilt the same remount key by hand, so the trick that makes a CSS animation replay was re-explained at every call site. Fold both subscriptions into useNowCuePulse and let it mint the key. Also flatten scrollToNowOrPulse's nested already-at-now branch into two reads and two statements, drop the dead motion-reduce:transition-none that rode along with animation-only classes (the pulse utilities already carry motion-reduce:animate-none, and none of these elements transition), and unexport the two grid helpers that only grid.util uses. No behavior change. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WpxnkYFrv7Y6BGCCQL55vM
…ple decode buildOAuthStateForClient became a one-line forward to buildSignInOAuthState when #4459 moved state building into the auth module, leaving a second name for one thing, an import cycle (desktop -> auth -> desktop), and a desktop flag no production caller ever sets: both web call sites pass false. The two callers now ask the module that owns sign-in state, and the desktop module keeps only the marker it owns. posthogDistinctIdFromAppleOAuthState's atob fallback was unreachable: base64UrlDecode already reads standard base64, since it only rewrites -/_ and re-pads, and it decodes UTF-8 where atob would mangle it. A string that got past the first decode and JSON.parse never reached the second, and one that failed them would fail again. Dropped, and the Apple state shape it exists for is now written down. Desktop's own test covered the marker through the wrapper; it now tests the marker reader directly, and buildSignInOAuthState's prefix behavior stays covered by signin-oauth-state.util.test.ts. No behavior change. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WpxnkYFrv7Y6BGCCQL55vM
Picking a start date built the same allDay schedule in both arms of an if/else, differing only in the end bound. One object, one ternary. No behavior change. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WpxnkYFrv7Y6BGCCQL55vM
tyler-dane
added
the
agent-automerge
Claude
tyler-dane
enabled auto-merge
October 15, 2026 10:37
Contributor
|
Boot bundle: 507.6 KB gzip (-0.0 KB vs main) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second half of the technical-debt sweep over the last 7 days of merged work. No issue; found by reviewing #4459 and #4454. (First half landed as #4476.)
What and why
A pass-through OAuth state wrapper, and the import cycle under it (#4459).
buildOAuthStateForClientbecame a one-line forward tobuildSignInOAuthStateonce state building moved into the auth module, leaving a second name for one thing, a cycle (desktop→auth→desktop), and a desktop flag no production caller ever sets: both web call sites passfalse. The two callers now ask the module that owns sign-in state, and the desktop module keeps only the marker it owns. Its test covered the marker through the wrapper, so it now tests the marker reader directly;buildSignInOAuthState's prefix behavior stays covered bysignin-oauth-state.util.test.ts.A dead decode fallback.
posthogDistinctIdFromAppleOAuthStatetriedbase64UrlDecode, then re-did the whole parse underatob. The fallback was unreachable:base64UrlDecodeonly rewrites-/_and re-pads, so it already reads standard base64, and it decodes UTF-8 whereatobwould mangle it. A string that got past the first decode andJSON.parsenever reached the second; one that failed them would fail again. Dropped, and the Apple state shape the function exists for is now written down.A duplicated schedule literal (#4454). Picking a start date built the same
allDayschedule in both arms of anif/else, differing only in the end bound. One object, one ternary.No behavior change in any of the three.
Verify
test:core(956 pass),type-check,lint, andknippass. Thetest:webfailure is the sandbox RSS guard, not a test:web shard 3/6 exceeded 5000 MB RSS. Same environmental failure documented on #4476:origin/mainworktree, stopping at the same file,SelectView.test.tsx.Worth a look separately: a full
bun test:webcannot finish locally because of that shard, on main as much as here.🤖 Generated with Claude Code
https://claude.ai/code/session_01WpxnkYFrv7Y6BGCCQL55vM
Generated by Claude Code