Repository navigation
fix(web): day view calendar columns at UTC midnight boundary - #5229
Queued
tyler-dane wants to merge 3 commits into
Queued
tyler-dane wants to merge 3 commits into
tyler-dane wants to merge 3 commits into
Conversation
Timed events were matched to the viewed day using civil-day strings in the effective timezone, which could drop secondary columns when UTC midnight disagreed with calendar-local event days. Use dayEventQueryRange overlap instead and apply the calendar TZ hint before paint. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Contributor
|
Boot bundle: 576.8 KB gzip (+0.0 KB vs main) |
Assert legacy civil-day column matching collapses to primary only at Nov 11 17:23 Denver with UTC browser and no calendar hint, while query-window overlap keeps both calendars. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
cursor
Bot
changed the title
Remove in-test legacy column matcher and restore LifeSidebarContent from main so #5229 stays scoped to day-view columns. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
cursor Bot
pushed a commit
that referenced
this pull request
Nov 12, 2026
Match web #5229 by overlapping timed events with dayEventQueryRange instead of civil-day start matching; add boundary XCTest and optional anchor timezone. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
tyler-dane
added this pull request to the merge queue
Nov 12, 2026
Any commits made after this event will not be merged.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dayEventQueryRangeoverlap (not civil-day string compare) so secondary columns survive the merge-queue UTC/Denver boundary.getDayViewCalendarsonly (no in-test legacy clone).Test plan
bun test apps/calendar-web/src/views/Day/components/Calendar/dayCalendarColumns.util.test.tse2e/calendars/calendar-experience.spec.tsday column test (shard 4 at UTC boundary)Fixes #5227 (flake dequeue)
VERDICT: pending CI on
a79e3b792