Repository navigation
fix(macos): week-view clamp for all-day edge nudges - #5242
Open
tyler-dane wants to merge 10 commits into
Open
tyler-dane wants to merge 10 commits into
tyler-dane wants to merge 10 commits into
Conversation
Port CompassKit edge nudge APIs, persist focused nudges before undo, and route hardware shift-arrows ahead of draft keys without altering main router paste, welcome, or life navigation behavior. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Route grid edit drafts through DraftNudge.nudgeScheduleEdgeByKeyboard when focusStore has a start/end edge, matching web shift+arrow edge behavior. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Mirror web wouldAllDayEdgeLeaveVisibleWeek for focused events and draft edge nudges, with CompassKit and FocusedEventShiftNudge regression tests. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Base automatically changed from
cursor/focused-event-shift-arrow-0084
to
main
November 12, 2026 17:46
Resolve squash conflicts and add draft-path week clamp regression test. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Week view on web refuses all-day edge nudges that would move the event outside the visible week (
wouldAllDayEdgeLeaveVisibleWeek). macOS focused events and draft edge paths now apply the same clamp viaweekViewClamponDraftNudge.nudgeScheduleEdgeByKeyboard.Merged
mainat 33bc76a (#5236) and kept clamp on top.Verify
bun run verify --strictat edd113c (local; macOS legs CI-only).AllDayEdgeWeekClampTestsFocusedEventShiftNudgeTests.testWeekViewRejectsAllDaySavedEventStartEdgeNudgeOffWeekFocusedEventShiftNudgeTests.testWeekViewRejectsAllDayDraftStartEdgeNudgeOffWeekNot queued or merged.